ssh: detect PartialSuccessError wrapped in BannerError#353
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
42022f0 to
33e1572
Compare
|
Fixes golang/go#79809 |
33e1572 to
1f9a96a
Compare
|
Rewrote the commit with |
|
This PR (HEAD: 1f9a96a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/790421. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/790421. |
|
Updated the PR description to address the Gerrit bot feedback: removed all Markdown formatting (backticks, bold, headers, code fences), wrapped all lines to ≤76 characters, and added 'Updates golang/go#79809' as the bug reference. |
Add errors.As unwrapping in the PartialSuccessError detection path so that a BannerError wrapping a PartialSuccessError is correctly recognized during the auth loop. Updates golang/go#79809
1f9a96a to
4f90cb0
Compare
|
Trimmed the commit message to plain text, ≤76 char lines, no markdown — per Gerrit bot feedback. Fix unchanged. |
|
This PR (HEAD: 4f90cb0) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/790421. Important tips:
|
ssh: detect PartialSuccessError wrapped in BannerError
Add errors.As unwrapping in the PartialSuccessError detection
path so that a BannerError wrapping a PartialSuccessError is
correctly recognised during the auth loop.
A new test TestPartialSuccessErrorWrappedInBannerError is added
to verify two-step authentication works when BannerError wraps
PartialSuccessError.
Updates golang/go#79809